Shareholders for Tesla and SolarCity approved a deal that has divided the opinions of analysts and investors.